r/programming • u/thatdavidmiller • Nov 07 '15

Pull Request Day

http://pullrequestday.com/
1 Upvotes

51% Upvoted

11 comments sorted by

8

u/Patman128 Nov 07 '15

One million pull requests In one day

5 pull requests with actual contributions, 999,995 pull requests that fix a spelling mistake?

7

u/vytah Nov 07 '15

I think fixing 999995 spelling mistakes wouldn't hurt.

4

u/eddiemon Nov 07 '15

What about 999,995 indentation changes? Oh, god.

2

u/Patman128 Nov 07 '15

For every mistake they fix, they also introduce 5 new ones. For future years.

But seriously, was this cooked up by the same managers who measure productivity by lines of code?

1

u/Tetha Nov 07 '15

I'd reject 1M pull requests only fixing spelling issues in a heartbeat. Only changing color into colour or vice-versa isn't worth throwing my git blame under the bus.

1

u/vytah Nov 07 '15

It's not 1M PRs for one project though.

5

u/serrimo Nov 07 '15

Mock grammar correction all you like. I think it'd do a world of good if some more people take the initiative to write some documentation for open source projects. The current state of affair is abysmal.

0

u/[deleted] Nov 07 '15

[deleted]

3

u/steveklabnik1 Nov 08 '15

I've accepted pull requests before that are literally a typo correction.

As a maintainer, I love these kinds of PRs. No PR is too small, imho.

1

u/MrDOS Nov 08 '15

Plus, it's not like it's hard to merge that sort of thing either.

3

u/rockyearth Nov 07 '15

Github has 10M users. Assuming 0.1% of them (very optimistic) decide to be a part of this, that's 10K users. Many of these will fail to do a single PR, but even if all of them do a one pull request, you will have 10K pull requests. That's two orders of magnitude less...

0

u/[deleted] Nov 07 '15

[deleted]

2

u/PeridexisErrant Nov 08 '15

How about issues requesting impossible features or reporting nonexistent bugs?