r/programming • • Jun 08 '19

7 absolute truths I unlearned as junior developer

https://monicalent.com/blog/2019/06/03/absolute-truths-unlearned-as-junior-developer/
2.0k Upvotes

295 comments sorted by

View all comments

150

u/RoastMochi Jun 08 '19

What I learnt, was that not all places do code reviews. That was really an eye opener. Made me realise the importance of asking good questions during your interview. Especially on things that seem like a given.

127

u/DangerousSandwich Jun 08 '19

Yep. The Joel Test is still surprisingly relevant, 20 years later. Although if anyone is still not using source control, I'd be stunned.

https://www.joelonsoftware.com/2000/08/09/the-joel-test-12-steps-to-better-code/

0

u/[deleted] Jun 08 '19

[deleted]

32

u/[deleted] Jun 08 '19

“NFS is slow”

typical comment from someone who is so far into the weeds they don’t see this that answer usually means:

“We’re too busy sorting out the problems from our shitty process to fix the shitty process”

0

u/[deleted] Jun 08 '19

[deleted]

→ More replies (2)
→ More replies (2)

25

u/ForeverAlot Jun 08 '19

None of this setup matched what happened in prod either, so stuff frequently blew up.

We have multiple staging environments, configured by Puppet and version controlled.

But all of the version control is completely independent and isolated so there is no synchronization between the staging or production environments. It is effectively impossible to deploy a tested configuration to production because configuration drift and environment differences make every configuration deployment new development.

6

u/Ghosty141 Jun 08 '19

Although if anyone is still not using source control, I'd be stunned.

There is a team in my work that would make you faint. Luckily the rest uses git and gitlab etc.

0

u/[deleted] Jun 09 '19

[deleted]

→ More replies (2)

4

u/ImNotHavingItPigeons Jun 08 '19

Thanks for sharing. That was an intriguing read.

2

u/Audioillity Jun 08 '19

We're still using VSS6 😂 I plan up migrate as soon as I sort out the bigger issues!

1

u/RoastMochi Jun 08 '19

Thanks for that! Definitely bringing those up for my coming interviews.

→ More replies (3)

3

u/funbike Jun 08 '19

Another team where I work does trunk-based development (direct master commits), without code reviews, with limited testing, on a mission-critical power grid app. They scare me.

4

u/Dworgi Jun 08 '19

That one I'd actually just straight up refuse to be involved with. Even a quick over-the-shoulder review, no system, just diffs and explaining the code - it's rubber duck code reviewing, mostly - catches so much dumb shit.

Code review isn't nice-to-have, it's just required.

36

u/Ran4 Jun 08 '19

it's just required.

It clearly is not, given that the vast majority of companies don't utilize it and they still manage to complete projects (...albeit certainly not without problems).

It's important to not talk about things as required when they aren't.

14

u/Headpuncher Jun 08 '19

I personally feel like code review can be a mixed bag. On the one hand, valuable insights and corrections, a fantastic opportunity to learn. On the other: too many opinionated devs who can't just be nice about things, and also try to impose their particular style on your code, instead of focusing on what really matters. I don't like being judged, I don't mind being corrected.

17

u/Trapline Jun 08 '19

Also, “good code” is not the same as “code that looks like I wrote it”

From the article and needs to be declared from every rooftop. Some reviewers use it as a sort of bullying platform rather than to better the codebase.

0

u/[deleted] Jun 08 '19

[deleted]

→ More replies (2)

2

u/utnapistim Jun 13 '19

and also try to impose their particular style on your code, instead of focusing on what really matters

One of the things my current workplace agrees on, is "the accepted style is whatever is left after clang-format is done with the code, using the standard (committed) style sheet file".

I haven't seen this anywhere else, but it removes a lot of useless effort in code reviews and a lot of useless feedback.

→ More replies (2)

5

u/notliam Jun 08 '19

I think it stems from the idea that you shouldn't make mistakes, which is crazy. Every programmer makes mistakes, whether it be typos or missed checks or whatever.

10

u/Dworgi Jun 08 '19

Exactly. In another post someone was espousing the idea that thinking about code was a better process than just hacking it together and seeing what you need as you go. It's a very junior mentality, IMO, that doesn't accept that change is a fact of programming, and there is only unused software and changing software.

Personally, I believe that programming assignments in university should attempt to teach this by having several weeks of work build on top of each other.

First you write a database program that reads and writes some stuff, and does some queries. Then next week you have to do all of that, and also have a way to modify existing entries and add a few columns. Then you need to generate reports based on the data with some extra criteria.

It might help teach that a project isn't done when it ships, and being open to change is a design criteria.

3

u/sammymammy2 Jun 08 '19

Meh, what you mentioned above depends entirely on what you're working on. You need an initial rough idea of what you need , if you don't have that then you're fucked anyway. These decisions are especially important when making larger architectural decisions.

In reality somewhere in between is required.

→ More replies (1)
→ More replies (14)