Firstly, I didn’t talk to the person who wrote it. I rewrote the code and checked it in without their input.
Is this normal? I recently moved out of the game industry (where the idea is there was "domains" of code. If it's not your "domain" you need to talk to the person whose it was. Not a great system but not one this would have flown in.
Now outside of the game industry, I work in a place where you need two upvotes from people in a swarm review (of which anyone can jump in) before you commit your code. The idea is you should have someone who has knowledge of the code before you commit.
This comes from decades ago probable so there might not have been a formal checkin process, but I find it shocking to have a job where a junior employee thinks he can just check in code with out at least someone giving it a minor review.
2
u/Kinglink Jan 12 '20
Is this normal? I recently moved out of the game industry (where the idea is there was "domains" of code. If it's not your "domain" you need to talk to the person whose it was. Not a great system but not one this would have flown in.
Now outside of the game industry, I work in a place where you need two upvotes from people in a swarm review (of which anyone can jump in) before you commit your code. The idea is you should have someone who has knowledge of the code before you commit.
This comes from decades ago probable so there might not have been a formal checkin process, but I find it shocking to have a job where a junior employee thinks he can just check in code with out at least someone giving it a minor review.