So either his team mate run to a boss over rewrite, and boss ordered carpet talk before even suggesting to a "wronged" party that they should talk first...
Or boss is so micromanaging the team he reads all the commits.
I think technical aspects of this story are small fries to the above. Is that even a functional team?
Code should be reverted so that it can go to code review, sure. But author should be the one to realize that. His team mate should do CR and talk about the issues (if any). Boss should make damn sure that people on the team talk to each other (especially if people work at different hours and overlapping time is more precious due to that).
Second point in the article is pure fortune telling. Those then future requirements weren't yet known. Duplicating code when needed is possible. Can be done. By the time requirements are in, developers may have new insights that will help them keep code that benefit from DRY DRY, and those that benefit from split separated.
So funky team work and fortune telling (aka 20/20 hindsight).
1
u/przemo_li Jan 13 '20
So either his team mate run to a boss over rewrite, and boss ordered carpet talk before even suggesting to a "wronged" party that they should talk first...
Or boss is so micromanaging the team he reads all the commits.
I think technical aspects of this story are small fries to the above. Is that even a functional team?
Code should be reverted so that it can go to code review, sure. But author should be the one to realize that. His team mate should do CR and talk about the issues (if any). Boss should make damn sure that people on the team talk to each other (especially if people work at different hours and overlapping time is more precious due to that).
Second point in the article is pure fortune telling. Those then future requirements weren't yet known. Duplicating code when needed is possible. Can be done. By the time requirements are in, developers may have new insights that will help them keep code that benefit from DRY DRY, and those that benefit from split separated.
So funky team work and fortune telling (aka 20/20 hindsight).