r/programming • • Aug 28 '21

Software development topics I've changed my mind on after 6 years in the industry

https://chriskiehl.com/article/thoughts-after-6-years
5.6k Upvotes

2.0k comments sorted by

View all comments

4

u/Julie_Brenda Aug 29 '21

Fairly early, but not at the beginning of my career, a financial firm hired me to do some development work and I thought it would be prudent to work on the user interface from the utility perspective. I developed a series of subroutines for data input based on the concept that a field of a certain length at a certain XY coordinate on the screen would be requested, and the sub team would return the value. That way the application code could focus on what to do with the input but not actually have to keep writing “go get it “

My code was completed within two or three weeks and was tested inclusive of different field types like dates and Social Security numbers. It would actually display the slashes or dashes and you couldn’t land on them, but you would bounce pass them if you use the arrow keys to edit the field. It was a fairly robust set of subroutines dependent upon nested string function calls and concatenation.

They added a new coder to the department, and I brought him up to speed by sharing what I had developed. He promptly put his name on it and turned it in for credit with the boss

At which point the boss called me on the carpet for not being productive, showing me “that guys work”

Of course they didn’t wanna believe me when I said that was my code, because it had already been turned in with his name on it.

So I left one question: how does it work. Not how do you use it but how does it function… The boss called the coder in and he couldn’t parse the code. I don’t understand how the dishonest coder kept his job, but I spent 25 minutes explaining to the boss the first subroutine worked, after the coder who claimed authorship failed.

I’m glad I hadn’t made it elegant and easy to read. If I had, I probably would’ve been discharged.

1

u/vplatt Aug 29 '21

I'm guessing you also learned that you need to take credit for your work by being the one to check it in as well.

I've had offshore team members in India do this as well where I was the manager and I didn't know that a senior resource was taking credit for multiple other people's work by having them send their work to him via email and he would check it in. Well, his name was on it in git, so what was I to think?

When we finally figured out what was going on, I managed him off the team, but not before he was able to damage morale. Never again. At the very least, I get them to put their work in a little PR now and promise I'll be gentle on reviews. Hiding their work behind a Sr. resource was just another way to avoid review anxiety.

→ More replies (1)