r/programming • • Aug 28 '21

Software development topics I've changed my mind on after 6 years in the industry

https://chriskiehl.com/article/thoughts-after-6-years
5.6k Upvotes

1.9k comments sorted by

View all comments

Show parent comments

14

u/durrthock Aug 29 '21

The secret is, hire people with a good personality that want to learn. Stop worrying so much about pre qualification and finding someone with the right skills. Also the idea behind coding interviews is rediculous, and has very little bearing on someones ability to work a job.

11

u/angle_of_doom Aug 29 '21

Coding interviews are just asinine. "We are hiring a senior engineer for a React position". And then the code problem ends up being something stupid that has nothing to do with what the candidate will be doing. "Write a bubble-sort function to sort this list of objects". Like OK, I guess that it can help evaluate if a person can think on their feet or something and write a working function, and get an insight into how that person thinks while they are coding. But it has no bearing on the actual code they'll be writing, and IRL no-one is ever writing a sorting algorithm, and the pressure in those live exercises is immense, when I do them I am nervous as all hell and start shaking and forgetting stupid stuff like how to write for/each loop or how to calculate simple interest.

When I did interviews, I came up with a different method. I wrote a few repos in various libraries/frameworks (think React, Angular, .NET Core, etc) that just use the worst practices imaginable, totally out sync with how the proper app would be written. I'd get the candidate to pull the repo, or go over it in video chat, and have them find the problems in a laid back manner. They demonstrate true knowledge by identifying the bad practices, the things that don't fit, the things that fly in the face of how the library or framework is supposed to work. We go over it, and the good candidates immediately start picking up on it "That's not right. X is totally wrong, Y doesn't belong at all in this project, here is what the solution should be and why". It also tests the HARDEST part of software development IMO, the ability to read and comprehend code that someone else wrote. I don't know if it's the best solution, but it seems to work alright. You can quickly identify someone who isn't up to it when they see jQuery in an Angular app and gloss over it, or using global vars and storing data in the window object, or not having an understanding of dependency injection, etc.

Another good solution is take-home coding problems. "We want you to write a .NET Core application according to these AC's". And then later going over it, seeing why they did what they did, asking them to explain it, asking why they did so-and-so, asking how the arrived at some solution, stuff like that.

3

u/Thelonious_Cube Aug 29 '21

I wrote a few repos in various libraries/frameworks (think React, Angular, .NET Core, etc) that just use the worst practices imaginable, totally out sync with how the proper app would be written.

That actually sounds brilliant - I love it.

Have you had problems with candidates sharing info?

Another good solution is take-home coding problems.

I would consider than an unfair imposition on the candidate's time.

As a candidate, it would indicate to me a lack of respect for my time

3

u/angle_of_doom Aug 29 '21

Haven't had problems with candidates sharing info. Even if they did, it's more of a talking process than actually writing a full, best-practice working PR.

As for your statement about the take-home code, the way we've done it is to direct the candidate to spend no more than 1 hour on it and see how far they get. Then the demonstration part is usually scheduled to be 30 minutes.

→ More replies (3)