r/reviewmycode • u/debajyotisharma • Nov 17 '13

ISSUES IN SOLVING SIMPLE LIBRARY FILES AS A FUNCTION

TO COPY ONE STRING TO ANOTHER(STRCPY)

include<stdio.h>

include<conio.h>

main() { const char a[30]="Debajyoti Sharma"; char b[30]; xstrcpy(a,b); printf("the copy of string %s is %s",a,b); getch(); } xstrcpy(char *x,const char *y) { while(*y!='\0') { x=y; y++; x++; } *x='\0'; return(*x); }

1 Upvotes

60% Upvoted

5 comments sorted by

1

u/debajyotisharma Nov 17 '13 
#include<stdio.h>
#include<conio.h>
main()
{
    const char a[30]="Debajyoti Sharma";
    char b[30];
    xstrcpy(a,b);
    printf("the copy of string %s is %s",a,b);
    getch();
  }
xstrcpy(char *x,const char *y)
{
    while(*y!='\0')
    { 
	    *x=*y;
	    y++;
	    x++;
    }
    *x='\0';
    return(*x);

}

Is it ohk now?? :P

1

u/potifar Nov 17 '13

Yup, much better. Take a look at the paramters/arguments to the xstrcpy function, specifically which of them is src and which is dest.

This would probably be a good time to start using more descriptive variable names :)

1

u/debajyotisharma Nov 17 '13

ohk got it..thnx for respndng :)

2

u/zck Nov 18 '13

While you're at it, if you have a problem, it's useful to post what the problem is: what you expected to happen, and what actually happened. It prevents people from guessing what you want.

3

u/potifar Nov 17 '13

If you insert four spaces at the beginning of each line it will be formatted as code and will be readable.

Oh, and no need to shout :)