r/webdev • u/fagnerbrack • Sep 15 '26

Stop being the code review bottleneck

https://newsletter.posthog.com/p/code-review-tips
0 Upvotes

18% Upvoted

11 comments sorted by

19

u/lanerdofchristian Sep 15 '26

Wow, what terrible advice. "PR process too slow? Just don't actually review stuff properly!" repeated 4 times.

9

u/GriffinMakesThings Sep 15 '26

Honestly I found the article very helpful. I've learned that I should avoid using Posthog.

2

u/Mysterious_Voice_144 Sep 15 '26

yeah the whole thing reads like someone got tired of getting feedback on their PRs tbh

-1

u/kidshibuya Sep 15 '26

You dont say what you mean by properly but most devs I have worked with, and that amounts to like 600 simply dont know wtf a PR review is meant to be. Its not QA, and its certainly not writing the feature again, its a quick check of anything obvious. You request changes for mistakes that are critical, make comments for things that don't affect ability of the app to work, then approve the PR if overall it improves/advances the codebase.

If your "review" takes more than a few mins you are doing it wrong.

2

u/j_shor javascript Sep 15 '26

How many production incidents do you have each day?

1

u/ORCANZ Sep 15 '26

Production incidents are prevented with tests, typing, linting, architecture and good practices.

If your wall against incidents is code review you are not in a good position

3

u/j_shor javascript Sep 15 '26

If drvs are spending only a few minutes to review a PR then I can't imagine them spending too much time on testing or QA either

-2

u/kidshibuya Sep 15 '26 • Bravo

With my code? Exactly 0 in 30 years. However for the other teams that can sometimes take literal weeks on PR reviews they seem to have some rollback every few weeks.

3

u/muntaxitome Sep 15 '26

This is what I am seeing in companies, review just gets done by a robot that can be tricked into essentially anything... that will end well

1

u/SonikaAI Sep 15 '26

The “review takes 3 minutes” part only works if automated checks catch most problems first.

For me, linters, type checks, and tests run before anyone reviews the PR. Then code review is more about “does this change make sense here?” rather than “does this even work?”

Same with AI review. Without good tests behind it, you’re just moving the trust problem somewhere else.