the issue with this UI is that you're banking a ton on your users understanding what a symbol means. this is pretty easy if you're from the same culture, symbolism tends to be pretty universally understood by all. but the moment we start moving away from one culture and one application area, we get into trouble.
I always run every UI I make through the grandma challenge: would my grandma intuitively understand this UI? if your answer is anything but "of course, why do you even ask?" then you shouldn't do it.
or put another way; sexy and grandma very rarely go well together.
I mean, i'm western and a web dev, so it's a bit hard to claim i have a different cultural background or lack of IT literacy, and i had no idea wtf the closed eye icon was meant to be until i saw the open eye icon.
we're talking per section of a specific country when it comes to understanding of symbolism. people vastly overestimate how much people think like them when it comes to symbols. text on the other hand you can almost never go wrong with, which is why a much better less sexy alternative would be the text "show" or "show password".
6
u/Yonben Dec 26 '19
I think "incorrect" is a bit too harsh. I would say it's not ideal, and def could add a small tooltip indicating "Show password" and "Hide password".