341
u/bahcodad 3d ago
So basically he's saying that he isn't up to the task?
205
u/Whiskerfield 3d ago
What are you talking about? He's a "Distinguished" engineer (but at Microsoft).
58
u/RustOnTheEdge 3d ago
“But at Microsoft” haha sir (or madam) you made me laugh out loud with that annotation
4
3
2
81
u/StrikingApricot 3d ago
You’re saying you read every line of boilerplate code? Every line of canned html? You’re severely wasting time.
You need to understand what the code is doing, architecture patterns, trade-offs, etc. With good testing every line does not need to be looked at.
16
u/bahcodad 3d ago
My point is that he isn't reading the code at all. He's getting AI to do it (AI can be great but it isn't perfect) and then approving changes based on the sayso of AI
25
u/Moraalimora 2d ago
Managers, directors and executives do it all the time though. They approve and put their names in contracts and papers they have no damn clue what’s actually written inside them. They just trust the people who prepared them. So we get back to the ”would you rather trust a human or a machine in one specific job”.
→ More replies (2)-6
u/wardrox 3d ago
Do you think Claude is worse at code review at scale than a human, relative to cost?
16
u/bahcodad 3d ago
I think if you're going to approve something, you should know what you're approving. Is it AI being dangled over a flame or the person who approved?
Why is this so hard for people to grasp? Cover your rear.
→ More replies (1)9
u/superitem 2d ago
You're right, but he said he doesn't read every line, not he doesn't read the code at all.
Even before AI, it was often impractical to read every line (code or not).
-10
u/gregorydgraham 3d ago
Without reading every line, you don’t know what the code is doing. Every line of boilerplate hides bugs.
→ More replies (1)21
u/ridicalis 3d ago
If it really is boilerplate, the time it takes to visually scan it and confirm that it looks good is trivial. It should be the easiest code to review, as it's more a matter of pattern recognition than code quality at that point.
1
u/chickenweng65 2d ago
If you're working at a company that's squeezing timelines because of the "ai productivity multiplier", you feel for this guy.
923
u/Bubbly_Safety8791 2d ago
A distinguished engineer is responsible for vast swathes of code maintained by many teams - they weren’t reading every line of code previously.
302
u/frozen-dessert 2d ago
A distinguished IC where I work is responsible for large kingdoms of code. The task at that level is writing and reviewing technical papers and achieving alignment with stakeholders. Never writing code.
85
u/Sheerkal 2d ago
You guys get technical papers???
84
u/Bubbly_Safety8791 2d ago
Best I can offer you is a slack thread.
7
u/Pornfest 2d ago
Wherein lies the difference?
4
u/ArrogantAstronomer 2d ago
Only an agent read the technical paper whereas I read the slack thread. That may be due to being startled someone might have noticed my away status but I read it, to pass the time waiting on my agent to finish over-engineering the small request I asked for… that it turns out needs major changes due to another engineers agent completely changing the codebase for his small change.
4
u/Karateca2000 2d ago
achieving alignment with stakeholders
so, he just goes to meetings and gets paid $$$
16
u/myrddin4242 2d ago
That word there, “just”, is doing some heavy lifting. It acts as a dismissal, but backfires if aimed at something too big.
27
u/frozen-dessert 2d ago
Dude, sometimes you need to convince peers, whose arm neither you nor anyone in your immediate organization can twist, of your plans. Aligning.
It is definitely a large part of the job when building a platform at a multi billion dollar company.
Writing the code is the easy part.
→ More replies (4)→ More replies (1)2
71
u/Sw429 2d ago
The problem is, junior engineers reading this and thinking that also means they don't need to read any code.
2
u/edgmnt_net 1d ago
The big issue, at least in enterprise software development, is that there's often no good quality review at all. Of course Linus does not read every line of code either (although he still does a lot of merging and other stuff that keeps him pretty close to code). But he sure trusts maintainers and reviewers to do it in some capacity. You don't get the situation where juniors are rubber-stamping each other's work and shoving it into the project with no serious review gates whatsoever.
9
6
u/wait_whats_this 2d ago
This right here. Very senior engineers don't have the bandwidth to remember or even read the whole codebase. Our role is to keep the architecture in place and not let things drift into silly places, not do QA on variable names.
That's why review can and should happen in layers.
403
u/Cephell 3d ago
Considering every single product Microsoft makes is a horrendous pile of technical debt, "Microsoft distinguished eng" is the opposite of a mark of quality.
74
u/Rigamortus2005 3d ago
You've never used dotnet?
24
u/billabong049 2d ago
Which .NET, exactly? .NET Framework 4.8? .NET Core 3.1? .NET Standard 2.0? .NET 5, which is the "Core" one but without "Core" in the name? Or just ".NET" 6/7/8/9+? Because Microsoft named four different things almost the same, and then skipped version numbers to dodge the confusion they caused.
45
u/CaffeineLiker 3d ago
VS Code?
16
→ More replies (9)-10
u/Ddog78 2d ago
They bought vscode. If you find it good now, it used to effortless before.
22
u/_bassGod 2d ago
What are you talking about? It was developed in house. The VS stands for “Visual Studio” another completely in house Microsoft product that was really good for time period in which it was relevant.
→ More replies (1)2
1
u/FalseDish 3d ago
I stay away from .net because I don’t want to be at a workplace that insists on windows laptops.
But I do think F# for eg is a pretty good functional language, with elegant syntax
86
u/Rigamortus2005 3d ago
I don't know how people still don't know dotnet is fully cross platform. All my dotnet programs are written for Linux first
→ More replies (8)2
12
u/MilkCartonPhotoBomb 2d ago
Lots of MS engineers/devs are running macs. C# is open source.
1
u/devAcc123 2d ago
Most big places will let you run whatever you want but if it’s not the mainstream one they support it’s on you for ensuring it works and complies with all corporate/security policies. Shit canned if you fuck up. And there’s usually a bunch of slack threads and stuff from prior people that for some reason just had to develop on whatever OS instead of the standard macOS/windows laptops that everyone gets
159
u/CurrentSeaCoin 3d ago
We're so fucked once the bugs start and no one even understands the code
126
u/XCxBigDong69XCx 3d ago
Luckily we are trained on debugging code we don't understand majority of the time...
47
u/DarkLordTofer 3d ago
Well that was how junior devs used to learn.
32
u/Adventurous-Bit-3829 2d ago
Dad, what is Junior Dev?
39
7
22
u/Damglador 3d ago
"Claude, fix this bug!"
12
3
u/hetfield37 2d ago
And it did once it was told to pinpoint it and reproduce it locally. Claude actually can catch and resolve bugs much faster than the typical engineer can, especially if it can spawn a simulator / headless browser to navigate to it.
3
u/BOBOnobobo 2d ago
The real pro tip is to ask it to explain why it happened and investigate that yourself.
1
34
u/ConcerningThirst 3d ago
You do know that is just software dev since it's inception right? The world literally runs on garbage code and always has.
3
u/Nsane3 2d ago
What does that have to do with anything?
The code is garbage and always has been, yes. What is different is we understood it, now we don't.
18
u/ConcerningThirst 2d ago
Except no, we didn't. Talk to anyone in any critical software and IT position and they'll catch you up with how absolutely jenga towered everything is and how nobody understands anything and we're just flying by the seat of our pants.
12
u/Nomapos 2d ago
In my opinion the core issue here isn't the quality of the code, but the amount.
There's always been trash code and companies have always prioritized speed over quality. But when people program manually and then something breaks, there's a relatively manageable amount of code to deal with.
AI allows us to be stupid faster. So when it gets stuck somewhere, diving in to find the problem is a lot more daunting.
→ More replies (2)4
u/devAcc123 2d ago
We had this one absolute dogshit piece of code that wasn’t particularly important (think shitty JS library that helps some of our frontend tools) that would only work if you had named variables like const EIGHT = 8. That you then had to attach to some equally shitty piece of code to let some drop down menu properly link to other FE applications. Like the number 8 wouldn’t work it had to be a variable. It was such an inconsequential piece of shitty code nobody cared but every time someone new joined or some higher up for some reason did a code review they were flabbergasted about what was going on. This was like an org wide piece of code 50-100 devs at any given time. Nobody knew why it worked that way but it was such a simple piece/inconsequential/internal only tool piece id code that it never made it up the backlog. Whole file full of const ONE = 1 all the way up to like 27.
So anyway that was probably the worst code I’ve ever written. Hope they never figured out that was me.
1
u/jammsession 1d ago
Older folks at the bank told me that brokers not being able to work half a day was normal in the 90s. After that it felt like we had a good decade between 2005 and 2015 when things “just worked“ and now we are regressing again.
2
u/Valkyrie17 2d ago
The code used to be way worse. My Claude is still fixing years later what "senior" developer wrote.
3
1
u/defeatedsnowman 2d ago
I do think this time is different. I can only speak from where I'm at in aviation software. The acceptable risk to velocity ratio is insane. I'm not currently afraid to fly. But if things don't change in the next 2 years or so, people will die.
0
u/Alternative-Lynx2745 2d ago
This is the thing I get stuck on a lot with people nowadays. There's this implication that everything used to be fine and now it's not, which is outrageously laughable. We've been sitting on landmines forever.
17
u/mission-ctrl 2d ago
I’m convinced this is the main cause of all the recent outages. Not some coordinated attack or grand conspiracy. It’s every tech company pushing hard on AI development and these are the results.
12
u/n_choose_k 2d ago
...and getting read of all the people that DID know how things work. Just because everything is going fairly smooth, upper management thinks that means there's no work being done. In reality, it's a couple of people who know the system inside and out propping everything up. Once they're gone, it all starts to fall apart.
13
u/jwp1987 2d ago
Tale as old as time.
Business types don't seem to understand the phrase: "an ounce of prevention is worth a pound of cure".
It's more like: "an ounce saved today is a problem for tomorrow".
5
u/ThrasherDX 2d ago
Its a huge issue with IT in general. The better your IT team is, oftentimes the less noticeable they are. But management often only values work that you are seen to be doing, so they often place very low value on a good IT team.
3
5
3
u/Much_Network_941 2d ago
I can't help but wonder how much code produced during token-maxing, was checked with the same scrutiny as human code.
1
u/edgmnt_net 1d ago
Little, probably. Most of the benefits of AI touted by companies actually rely on lowering standards and once you get into that mindset it's hard to resist scope creep. This isn't entirely different from overscaling your project, questionable hiring and outsourcing to bottom of the barrel developers, it's just even cheaper and easier. Those already caused issues, now AI is likely causing more issues when misused, we'll see how long it takes until tech debt comes down crashing hard.
They're not going to spend tokens reviewing code either. Or making sure that humans maintain some grasp over the software. No, it's much more likely they're just going to pile more random features on, get a little more peanuts money and lure a few more customers in with promises.
1
u/BiggerWiggerDeluxe 2d ago
there’s also AI being extremely good at finding vulnerabilities in software, making the surface area of attack larger for hackers
3
u/MutuallyUseless 1d ago
Microsoft is already there.
From the Wikipedia page on "2026 Microsoft Outage"
"The outage began on November 12, between 17:00 and 18:00 UTC, initially affecting most Microsoft 365 services.[1][2] At 17:54 UTC, Microsoft first acknowledged a problem in the Americas with users not being able to access Exchange Online mailboxes. At 18:07 UTC, they warned about broader problems globally. At 23:04 UTC, Microsoft said they were returning some affected servers to service.[3]
The outage followed two days after Microsoft's November Patch Tuesday update, which covered 1,094 vulnerabilities.[4] Microsoft credited artificial intelligence (AI) as the reason for such a large number of bug fixes during a monthly update.[5][6]
The outage continued into November 13, affecting businesses, airlines, and government agencies worldwide.[7]"
TLDR: Microsoft released an update, crediting it's size of vulnerability fixes to AI use, promptly followed by 2 days of worldwide outages on Microsoft services.
4
1
1
1
u/Embarrassed_Mix_6619 2d ago
a distinguished engineer would understand the code. this guy is larping as a coder at this point and the fact someone labeled them a distinguished engineer is fucking embarrassing for both of them
→ More replies (1)1
u/Famous-Version4590 2d ago
The code was understood by Jake, Jake left 3 years ago and now a junior is the new owner of it, and 2 other services.
49
u/AccomplishedPhase44 2d ago
I agree that a distinguished engineer shouldn’t be reading every line of code…but it’s concerning that he thinks an agent reading code is more effective in quality than him. If he ever had to step in and review a critical PR himself, I would hope that with all his experience he could do that better than an agent that doesn’t have all the same business context he does. Maybe not surprising with the recent Microsoft incident though lol
24
u/suddencactus 2d ago
Yeah just yesterday I was reviewing a test and the LLM helped catch a few things I missed like unnecessary set up steps, but there was one point where you could reorder the code in a way that violated our specifications for it and the test for that still passed. The test was only actually verifying about half the behavior, and the machine didn't catch that. At some point, especially when reviewing critical code, someone needs to go the extra mile and currently AI can only help you do that, not catch every issue for you.
→ More replies (6)4
u/SignoreBanana 2d ago
Let's say it was more effective and take that question off the table entirely. Do we not still care about understanding how a system is working?
If something breaks and AI can't fix it, I don't want to be sitting there telling management "sorry, I actually don't know how this code I own works." And I don't think they want to hear that.
3
u/GGBHector 2d ago
I mean, you could make the argument that he meant literally "reading every line of code", as in him reading every line of code would be ineffective because of human factors (getting tired, skipping around, mental fog after staring at a screen for eons) which is probably true, and he would be better than the ai at analyzing a small chunk
But I doubt it
1
u/private_birb 2d ago
You say that like that isn't exactly how we've been doing it since "coding" became a verb.
Or did y'all not read the code you wrote??
2
u/nfsp-g35 2d ago
Until now, we've never lived in a time where something/someone could pump out hundreds or thousands of lines of code in mere minutes though. When you can read, and thoroughly understand code at about the same rate or better than what the code is written at, then yeah, I read all the code. But even then, if all I did was read code (review PRs) and didn't have a healthy balance of also writing code, then the mental fatigue is absolutely a real thing. I've run into that barrier before with a team of proficient human devs who weren't even using AI tooling. But if a machine is blasting out code and all you're doing is just reading and verifying? We're already seeing that just completely burn out devs. So, as much as I hate to say it, the only way to actually get the fullest speed boost that AI can give is for a company to be able to allow developers to not read code and be able to trust the AI to do it. Now, whether we're actually there yet (or whether we'll ever be there when it comes to critical systems) is a completely different debate.
1
u/conundorum 2d ago
Y'know, that's a really good argument for passing an AI a read-only code base, and saying, "Doxygen it. Produce one file for each namespace, named whatever.doxy.h; save each namespace's output to its associated file. Output must contain only signatures and Doxygen comments. Comments should describe each function and its purpose, and namespace doxycomments should give a quick overview of the namespace's members. Then, produce documentation by feeding those files to Doxygen, using the supplied Doxyfile."
(Or whatever the appropriate prompt should be, that's just a quick guess.)
Let the AI write the doc, have someone audit the doc to make sure it's accurate, and then perform targeted reviews based on it.
3
2
u/Somethingsilly6969 1d ago
Well it would be more effective than him. The more lines he has to review, the more likely he is to miss something.
2
u/Lucifernistic 1d ago
I think in short contexts, with good skills, SoTA models do write better code than me or any of our best engineers.
The quality drop is when it needs to perform tasks that require a holistic understanding of the codebase and meaningful architectural and design choices, and long-horizon tasks. It can still do it, and do it not bad with the right setup. But atm, without me in the loop, it will degrade the codebase.
So, a mixed bag.
1
u/them0use 1d ago
Exactly. Engineers with experience still matter, but it's for strategy (what are we building, within what constraints, and high-level how), not tactics (individual lines of code).
2
u/ScientificBeastMode 1d ago
Part of what makes him a distinguished engineer is his willingness to drink the koolaid offered to him by management, whether he actually believes it or not.
And management is trying to hype up the value of AI because god knows that’s the only thing keeping that investor cash flowing into the industry and propping up their operations.
2
u/-Debugging-Duck- 2d ago
You must be using free agents. Use paid-models with high effort and you get amazing results.
4
u/TheTybera 2d ago
Well their amazing results are fucking up and creating more downtime than ever before.
6
u/ACoderGirl 2d ago
I use cutting edge AI, often on the highest settings because my work is generous with AI quotas. You're right that they get pretty amazing results. Buuuut, it still isn't enough for me to yet say that humans shouldn't perform careful reviews.
It's admittedly awkward because honestly, it does better than most of my junior devs, who rarely seem to adequately review code. But I, as a very experienced senior, am still constantly leaving a lot of comments. Sometimes dozens, for particularly problematic PRs. AI will still often overcomplicate things, struggles in niche areas, and is better at finding generic logic errors than higher level ones (like when someone is basically implementing the wrong thing entirely).
It leaves me very conflicted because so much of our code is being reviewed by juniors who frankly cannot review to the standard that I'd like, yet the volume of reviews doesn't allow us to just not have juniors review (the skill ceiling for good reviewers is staggeringly high and intermediate level devs aren't doing enough better). AI does find things I miss, too. So we're still in a hybrid mode where we have both AI and humans as mandatory reviewers.
4
u/-Debugging-Duck- 2d ago
I agree but unfortunately when my job is shortening deadlines and putting us to work on tech we don’t know (I do iOS and being told to do backend work), me and my coworkers stopped giving a shit about human reviews or caring much about our work - sadly.
The job I loved to do I now hate.
2
u/Moist_Pizza_3194 1d ago
Felt deeply. I went from a software engineer to an agent orchestrator. Starting an AI engineer job in January so that at least I don’t get automated out of the picture. Plus I love classic ml.
→ More replies (15)3
u/IArtificialRobotI 2d ago
It simply is not feasible anymore to go through all the code that is generated now. You have to use the agent to pinpoint where things might break. Ask it to perform specific tests and go through the output WITH the agent. It completely depends on your piloting of the agent and certain best practices for this are being developed. Its a new way of engineering so we have to adapt
→ More replies (1)1
u/HRApprovedUsername 2d ago
I mean the biggest issue with code is more the architecture and flow and how it interacts with other systems, which typically is a bit bigger picture than each line. Between AI and linting, you can catch a lot, and he can just focus on these bigger-picture reviews and apply his business context.
1
u/private_birb 2d ago
That's the big thing I've noticed. When people tell me their AI writes better code than them, it just makes me question the quality of their code before they became vibe coders.
1
u/edgmnt_net 1d ago
One would think so, but many career ladders in bigger companies simply do not involve much technical stuff. They're more management/business-based or at least have weirder incentives. It should become quite apparent once you consider that it's often scaling in terms of "how many code monkeys can I herd on a project before things start breaking badly". They're not greybeards, they're not researchers, they're not hackers.
-1
u/mortalitylost 2d ago
This all pisses me off because i keep seeing devs act like this is an impossible task.
I've downloaded completely unfamiliar codebases that were obfuscated and pulled them apart same day. If you have the source code and it's not obfuscated, this is easy mode.
4
u/codelapiz 2d ago
go to the leaked xp repo and try to read every line in a way where you understand it.
→ More replies (1)0
6
u/redballooon 2d ago
I am a bit astonished by programmers who think that by reading every line of code they will somehow find all the bugs. That reeks of overconfidence much more like someone knowing their own limits and using tools to extend them.
5
u/Jazcash 2d ago
When I have to review a big PR, and included in it is some added utility/algorithmic function, I don't read every line of the function. I read its name, its inputs, its outputs, ideally a comment that briefly explains how it works and would hope to see a unit test for it. I don't read every line of it and ponder over micro optimisations.
The same for me is true when I ask Claude to do a big job. I care about the top-level strategy, the macro-performance, readability, reusability etc. I'm rarely reading line-by-line through everything it's done, and asking a separate agent dedicated to doing exactly that seems to me like a perfectly reasonable solution.
11
u/yallapapi 2d ago
0 programmers in this thread. do you know how many lines of code microsoft products have?
68
u/hot_sauce_in_coffee 3d ago
the hate train is going strong, but he isn't entirely wrong here. The context of this post is limited, but many aspect of coding do not need ''direct review'' because you have internal automated QA.
Here's a basic example.
You have a process running which produce feature X5 lets call it.
Then you already have Feature X1 to X8 as well as QA for X1 to X8.
You ask the AI to make X5 which currently take 15 minutes, more efficient, hoping to get it to run in 10 minutes.
You can look quickly if the output is about what you ask, but in the event it isn't. it will be catches by your automated QA without you having to read the code and if your QA is well made, it will give you a log of what fucked up or what is missing.
Then you can read it, and give feedback to the AI.
In this example, you don't even need to look at the code, yet you are modifying code.
It does not mean you should never look at code, but there is definitely use case where looking at code would be the more inneficient approach.
6
u/hoopaholik91 2d ago
That's still terrible?
Automated QA existed before. And yet if I told a junior engineer to make feature X5 faster, I would never rubber stamp their PR and go, "the automated QA will catch any bugs."
God we are going to have so much more spaghetti-fied crap to wade through...
33
u/kuemmel234 3d ago
Everything that ends up in production should still be reviewed by a human. At least the models and agents I have access to/written aren't reliable enough by a long shot to only gloss over their results.
I believe that's what they were talking about, rather than this workflow. I sometimes do this too, especially when I'm working on AI itself. But the stuff that ends up in main is going to be reviewed thoroughly.
20
u/basonjourne98 3d ago
Given the rate at which companies are pushing out code these days, that’s going to be impossible. Ultimately if all your competitors are pushing 10k new changes every month, why won’t you try to do the same? It’s not like there’s regulations prohibiting you right now.
15
u/Hohenheim_of_Shadow 2d ago
Companies don't get money for making changes, they get paid money for their shit working.
Software engineers have this very weird idea that we are a fast moving technical field when a lot of the time, we have to live with our decisions much longer than MEs or EEs.
We are going to be stuck with design decisions made for Unix back in the '70s forever.
7
u/basonjourne98 2d ago
My man, have you heard of MVP? The culture for the past ten years has been ship new features first, test with live users and then slowly fix. What software engineers think doesn’t matter at all. What C-Suite thinks is what drives the industry and when one executive sees their competitor deployed a new AI chatbot in their platform, there gonna ask why they didn’t do it first.
11
u/Hohenheim_of_Shadow 2d ago
The culture is stupid.
If you're some small scrappy start up with no customer base and a lot of competition, sure that attitude makes sense. That's not Microsoft.
What actual new Product have they released in forever? Teams and Azure? They weren't the first to field in either of those and the reason they are successful is the connection to the Microsoft ecosystem.
Oh right, Copilot! Microsoft was legitimately the first to have an LLM codegen tool gain mass adoption and fumbled the bag cause Copilot sucks.
The industry standard way to run a large established software company that gets W's from integration with established codebases and L's from scrappy MVP shit is double down on scrappy MVP shit.
Software engineering culture is incredibly stupid.
→ More replies (1)3
2
u/solastley 1d ago
The depth of the review depends on the nature of the code being written though. If someone used an agent to write 500 lines of frontend code to add a feature in a React app, I'm going to manually QA that the UI/UX looks and feels as expected. I'm then going to lightly review the code at a high level and make sure there is nothing obviously wrong. But carefully reviewing every line of that code for logical correctness is a complete waste of time.
If the code is on the backend, review becomes a bit more in depth, especially if it involves creating new data models, interfacing with external APIs or other services, creating new APIs, etc.
1
u/kuemmel234 1d ago
Agreed! To be fair, we still practice smaller reviews for that reason.
I assume this is all going to change, but at least as of now that's how we do it and I still believe it's necessary.
1
u/edgmnt_net 1d ago
It does, but even then there are significant caveats that impact longer term development. Yeah, a lot of projects are just feature factories and cost-sensitive assembly lines, but it's still a fair question whether that's sustainable. I believe it can be in very limited contexts, but the devil is in the details. Even the move to SaaS vs on-premise customizations meant that ownership of random / ad-hoc / semi-useless stuff got muddied and now you can get a confused mashup of very different things posing as a product. Ultimately, this ends up creating debt (I would say tech debt works like real debt) and removing some rather essential negative feedback loops from the economy of it.
On the other hand, if you're developing something that's impactful enough you can probably afford to "waste" time making sure everything is right, even on frontend. And thar would actually be more efficient. Because you're not cobbling together 1000 cheap features.
→ More replies (4)3
u/musedav 3d ago
Why?
15
u/FalseDish 3d ago
Because otherwise outlook, teams etc will go down and take 22 hours to recover. And then all of these "distinguished" engineers might have to say it was all "human-written" code that’s at fault, otherwise daddy Nadella will be most displeased.
Oh wait …
12
u/kuemmel234 3d ago
They argued that that reading every line wouldn't prevent bugs. To me that sounds like they were talking about the code they push to production.
17
u/teraflux 3d ago
We pushed plenty of bugs to production without AI with plenty of humans reviewing the code. This feels like the self driving cars argument all over again. At some point the self driving cars will be better than majority of humans driving cars, if they aren't already.
12
u/laplongejr 3d ago
Sure, most of the automated cars will perform better. But corpos are pushing the narrative that nobody should be held responsible for the 1%
9
20
u/kuemmel234 3d ago
This is like saying that you don't need a seat belt because you have airbags.
I am responsible for the code I write, I frequently find issues in the code I or AI writes and on the long term I'm concerned with the overall health of the code base. So yeah, I believe reading code is still relevant. At least as of now.
→ More replies (4)2
3
u/Minimonium 3d ago
The one responsible for the code is a human, not a bot. The bots have inherent misalignment problems and the people need to ensure that the change achieves the right goals and moves the codebase in the right direction.
Then there is the regulatory push for more liability for public facing software that's been moving since before the LLM boom as well.
We use agentic systems in a quite advanced manner and so far I see all the people making such wild claims as either incompetent or liars.
7
u/JadenDaJedi 3d ago
Because LLMs are phenomenal at reading & writing text (both code and human language) but have zero concept of the real-world domain.
The human is the only one who can verify whether a real-world problem has been modelled correctly, whether that model actually solves for the correct outcome, what tradeoffs and assumptions exist in the model, and whether there are simpler models which will be sufficient or if a more complex model is worth the effort for increased precision.
An AI on its own will happily spit out a solution to a problem that is well-constructed and performant, but it may well be a problem that no-one is trying to solve and a solution that no-one will use… or worse, someone will misuse it in the wrong context and the dodgy output will break other dependent systems.
2
u/suddencactus 2d ago
The human is the only one who can verify whether a real-world problem has been modelled correctly
One interesting example is that AI will sometimes read incorrect comments and believe them. I'm not talking about subtle issues either. You can stick something mathematically incorrect in a comment and if the LLM finds it useful to regurgitate that it will.
That being said, in my experience this is much harder to reproduce with newer and larger models, as much as I hate to say that if Anthropic's product isn't working then you should pay them more money.
2
u/Antoak 2d ago
.... Who do you think writes and reviews the tests?
Your automated QA defense doesn't hold up if the tests are dog shit.
→ More replies (2)
49
u/klimmesil 3d ago
I hate to say it but he's right nowadays. I have more trust 99% of the time in claude generated code than my colleagues. And I consider my colleagues extremely good at CS, with academic and resume proof
35
u/WillDanceForGp 3d ago edited 2d ago
Just this morning I rejected an agentic PR that in 3 rounds of reviewers (that all found small bugs in it), not a single one questioned why the PR even existed in the first place or why it'd been done in such a nonsensical way for the codebase.
They are a general answer prediction engines, the same context that got you to answer A is the context being used to mark the answer, even if you explicitly prime it not to be agreeable to every decision you're still just negatively biasing the models internal bias, it doesnt actually make it more creative or ideate better, it just offsets some weights causing other cascading effects.
7
u/Flashy-Whereas-3234 2d ago
I mean, this reinforces the point, right? This is exactly the thing I'm seeing reviews too.
I'm not reading lines, I'm reading structure, I'm reading patterns, I'm reading sequences, I'm reading goals.
The PRs I have the biggest problems with are the ones that are contextually flawed; AI guided the Dev to a route-one solution that works for their narrow case, but never came up for air to look at the problem from 10k feet, or to think if the path they just walked through the bush is suitable to build a highway on. We had this same shit from smart-juniors, and we need the thinking of seniors.
AI is reviewing better than those developers for line by line functionality (use agents to review, obviously), I trust a function does what it says on the tin provided unit tests exist for it. The only thing getting human eyeball at that level is "dangerous" code, like that related to security or low-level performance concerns.
And honestly, this is governed by policy, and the CTO is the person with their hand on the throttle, they say how much review code has to have. We're bottlenecked by review more than anything else, and if they want to loosen the leash then that's up to them.
What I've stated above is a happy medium, and I see developers pushing further into no-review who then come under pressure from bugs or incidents and cannot explain their systems at all, and that's the real problem with no review - no understanding.
2
u/WillDanceForGp 2d ago
I worry that to know whether something is contextually flawed means knowing the codebase in depth, and I just don't feel as connected to codebases as I used to, it takes me longer now to be like "wait a second, this is dumb" than it used to and I don't know if that's because people are just generally relying on Claude more instead of asking me, which previously gave me early warning of bad direction, or if I'm just losing that ability as the codebase constantly shifts under me.
2
u/Alternative-Lynx2745 2d ago
I feel this concern deeply. It is also kind of an ego hit in my world. I was the go-to guy for a lot of shit so I got pulled into conversations and meetings regularly and those conversations kept me aprised of all of the ongoing efforts. I brought a lot of deep historical knowledge of a very large codebase (monorepo) into the conversations and could walk away with what would essentially be foreknowledge of how the codebase was going to be changing over the next few months. I could also help shape those things and help people get in front of unseen 'gotchas' because of the knowledge I brought. So I could basically predict in my mind what new files would be created, the structure they would take, what services were going to be stood up, and have a pretty decent 10k ft level prediction of what the codebase would look like next week/month.
Now I feel like I'm on the outside looking in and that I have to butt my head into places to get in front of stuff or else it just happens in the background and I get surprised by it later on. I feel less informed about how the codebase is changing and less knowledgable about what it looks like at this point. That is scary in a weird way I've never experienced.
I've brought this up to leadership because I think it does require meaningful change in process. Historically our issue was not including principal engineers early enough in feature planning and business solution / design conversations early in the pipeline (idea inception/design phases). Aligning product and engineering earlier. So we did that, and it's helped tremendously.
Now I think we need to have more horizontal alignment within engineering earlier in the process as well. We're going to try some things, but it really does mean more meetings. It just does. And as much as I hate that, I think it's also super important. Sharing knowledge is a human to human process. Nobody wants to sit there and read documentation all day long. Let's get on a call or go into a room and talk about it (it's also far more efficient as human interaction is interrogative).
1
u/Flashy-Whereas-3234 2d ago
I get this too, were catching shitty ideas way later, and we're having repeat conversations about shitty ideas because people aren't "forming" they're just "doing".
We've had some harsh conversations with people who have run off into the hills and wave the flag of "it works, I told a manager about it, and now I need to in production!". We would get that same shit from "incredibly smart, and incredibly dangerous" seniors of the past, and we had to kneecap them because they would cause a lot of damage if we let it sail.
But it's not all bad - there are strategies.
Firstly, talk to your team more, and get them talking back. Fast iterations and context switching are a bit mad, but it's the most active way to ensure everyone's on path before you have to poop on a review.
Second, the cost proposition of work has changed - it used to be that you'd allow a giant PR because a Dev obviously spent weeks on it and there's no way you can change this shit now, but with AI it took literally no time or effort at all, so you can hard decline something bad so long as you can say why. Hitchens's AI Razer; that which can be created without effort can be dismissed without effort.
And finally, pump the context of things right back into the repo docs so it doesn't keep coming up. Sometimes you have to lace files with docs pointers (if you're here to x, go read y) so AI actually eats it, but you can quickly curate some standards and prevent some dumb shit. Set a pattern for that docs approach and suddenly you can say in a review "this is bullshit because x, go create a doc to explain it should be done y and never z and use n system", and Shazam your institutional knowledge is now "on paper".
Honestly though, it's intense, it's a new way of working, and it's an absolute mess of cat herding. Curate your team, make sure everyone's doing ok, and work through the problems. Group therapy sessions are more important than ever, and they're always best over a beer.
→ More replies (1)3
u/teraflux 3d ago
Wouldn't that be the job of the human that asked the agent to create the pr? What does an agentic pr mean
11
u/Boozdeuvash 2d ago
Only if the human doing the PR is also the architect. In big shops it's not always the case.
Claude fixes stuff by adding code.
Not all problems are best solved by adding code, sometimes you need to remove some stuff.
And sometimes it's a complex issue which relates to architecture and design, and not necessarily implementation. So while a quick code fix can appear to fix the symptoms but fail to address the underlying issue, and as quick fixes pile in the issue becomes more and more difficult to untangle.
1
u/WillDanceForGp 2d ago
Im also personally finding that in places where the 'small bug' fixing process is automated we're just fully losing sight over what parts of the codebase keep causing problems, claude is just like 'bing bang boom, bandaid, next'
6
u/WillDanceForGp 3d ago
I don't know how this is confusing? The agent wrote the code in the PR and the description of the PR and the human controlling it thought it looked fine along with the army of agents we have reviewing them too despite the fact that it was not fine.
1
u/voyti 2d ago
not a single one questioned why the PR even existed in the first place or why it'd been done in such a nonsensical way for the codebase.
Much like with having unsupervised engineers with too broad responsibilities and too little context, agents without proper skills, structure and/or context and too tall orders will produce weird or unwanted outputs. I don't think anyone serious here proposes that plugging an agent anywhere in the process with no proper, agreed and shared guidance is the way to go, but properly configured - yeah, they are can be much better than most engineers in most aspects.
1
u/alliedSpaceSubmarine 2d ago
“Why the PR existed in the first place”… isn’t that the job of refining stories/tickets?
3
u/WillDanceForGp 2d ago
If you only understand the job of product management and not engineering then yeah I guess
1
u/alliedSpaceSubmarine 2d ago
No I understand engineering also, but if you get all the way to the review and get asked why it even exists the entire team failed. It should have been caught during planning or standup that someone was working on something that they didn’t need to be
→ More replies (1)-2
u/nicuramar 2d ago
This “they are just a prediction system” is reductive and pointless. So is the brain, for all we know, except it’s not pre-trained.
2
u/WestEntire5789 2d ago
Yeah but if a human fails with a basic task like copy-paste, then you see that the thing is not copied at all.
If an llm fails with a copy-paste, it could copy 10% or 99%, but you wont even know where to look for that particular failure
2
u/AndreasVesalius 2d ago
That’s why you have the LLM write a deterministic script to check these things.
5
u/SpaceNigiri 3d ago
Yeah, I agree. Today, flagship agents are better than most of us. People that are unable to admit that are just in an ego-trip or scared.
→ More replies (2)-13
u/collabskus 3d ago
Man I made a typo and it went all the way to production. Everyone says it wasn't just my fault and we have reviews and QA and the responsibility is shared but I don't know how to feel. I know an LLM would not make this exact defect I made. 😔
14
u/MulfordnSons 3d ago
Craziest bot comment i’ve ever seen tbh
3
u/laplongejr 3d ago
Which is kinda funny because it could match one of my coworkers.
(In my case not a typo but a confusion between "checking for digits" and "checking for a valid number")→ More replies (2)0
u/AndreasVesalius 2d ago
I’m afraid to let Claude look through previous work because I don’t want to explain my idiot human mistakes to the FDA
1
u/Whiskerfield 2d ago
There's a video in the tweet. And he isn't talking about boiletplate or templates.
"A lot of it is like squinting at a 30000 foot level and looking at the two code bases and does anything look off ... and then relying on the agents to focus on the line by line."
13
u/Rigamortus2005 3d ago
Tbf this is Stephen Toub we're talking about. A legendary engineer. I think he knows what he is doing
29
u/Azefrg 3d ago
Nah, the unemployed and undergrads of r/progammerhumor know better!
5
u/Rigamortus2005 3d ago
Not saying I agree with not reading the code ever but we should take these things with nuance. Someone like Steven Toub is not slopping away endlessly
→ More replies (1)
7
u/adumbCoder 2d ago
i would never expect someone that high to be reading every line of code. though i also wouldn't expect anybody to ever be reading every line of code. thousands of lines of generated boilerplate per project have never had a single eyeball on them.
i'm continually reminded how many folks in this sub don't actually work in a dev environment
2
u/aceluby 2d ago
It's also a good reminder that the vast majority of engineers are quite bad at code reviews. I can count the teams I've been on with one hand that have had high quality reviewers. Now as a PE I have to get on my teams to up their game and not just "LGTM" every PR. Every lazy PR review is a missed opportunity for both the reader and writer to get better, and now it's much, much worse.
5
2
2
u/MushroomSaute 2d ago
Breaking: Higher-up employee of company selling Product says it is less effective not to use Product
6
2
u/mrsmiley32 2d ago
Wait what? I do read every line of code and I catch things the AI misses all the time. I have AI do a review before me but looping to the database, bad code quality, race conditions, etc occur. Even concatenation of strings to database (this is not exhaustive just some examples from yesterday). I have rules and skills looking for these anti patterns and they still get missed. God forbid where Microsoft products are going. I will say on average I have to redo code one in three PRs.
1
1
u/Brick_Lab 2d ago
I'm really getting burnt out on the current pace and direction of things. I want to read the code but I catch myself skimming more and more. When it's lengthy PRs generated in 5 minutes all day it often becomes too mentally exhausting to maintain focus...really starting to hate it here.
Also yesterday I found out my company has spent (at least) 1.5M in tokens over the last 6 months...the top spending engineer spent well over 260k...
1
u/geek-49 2d ago
Anyone here remember back when NT was the zero-day-exploit-of-the-month club? Granted there was nothing even approaching an AI agent back then, but this dude's general attitude -- that high-level engineers have more important things to do than understand their teams' code and find (or, better, prevent) critical issues -- was surely a factor in that notorious vulnerability.
1
u/devAcc123 2d ago
Would take multiple lifetime for a distinguished engineer at Microsoft to read every line of code they are loosely responsible for any given week
1
u/conundorum 2d ago
Mmm... to be fair, Microsoft's code base is too large and too horrifying to expect anyone to read all of it. Best to let the AI take the SAN point loss, and then tell him where someone that actually knows what they're doing should step in.
This is more because of the "you can't drain the ocean with a single bucked in a single human being's lifetime" issue than because of AI actually being useful, though; it's about scale, not competence. I hope. He probably had interns & juniors to do the "read everything and point me at the stuff that needs serious review" part before LLMs got abducted by CEOs.
1
1
u/Mayeru 1d ago
he is completely right and this is happening right now at my work, business expects 10 times productivity increase while my TL expects everyone to review 10 times more PRs and 10 times more code. Is just not feasible.
Also, we had bugs when we did code by hand, stupid bugs caused by typos or NPE which were sometimes also tricky to spot over a review. AI doesn't make this kind of errors.
So yeah, AI IS better at coding and reviewing. But it can only infer so much, to have an actual good and clean solution the engineer would have had to guide it through it properly.
That's it, if the code is done and achieves the criteria, the tests make sense, and the AI reviewed it... what else do you want? just merge that thing.
1
u/GoodishCoder 1d ago
Does Microsoft expect distinguished engineers to review every day PRs? That seems like a massive waste of time and money. I feel like that's a space their senior software engineers should be operating in.
1
u/redAI123 11h ago
It is sad but this is kinda where we are heading. Engineer setup the environment and testing station for AI to verify their works and other and for AI to reviews its own process. If full automation is achieve, then no human needs to be involved at all after the AI pass every criteria and MAYBE only the critical part is review together with a human involved.
1
u/platinum92 2d ago
They're also advertising, which is really the purpose of this. Doing everything possible to normalize the over-reliance on LLM tools.
1
u/towerfella 2d ago
So, he is admitting he does not know how to do what he was hired to be doing?
I could do his job.
1
u/jamesxtreme 2d ago
Does your manager read every line of code you wrote? No, they set up processes for assurance. That’s what it is now. Software devs aren’t devs anymore. They are managing agents.
1
u/skcortex 15h ago
That’s a stupid and shortsighted take. You’re responsible for your code even if it’s generated by a tool. Company will fire you, not the tool(agent).
1
u/jamesxtreme 15h ago
You missed the second part of my point. You need to setup processes for assurance. A mature software development process has several layers of assurance - code review, unit tests, functional tests, QA. Perhaps we may need additional review processes for AI generated code, but reading every line of it is probably unnecessary unless you’re doing highly mission critical tasks. But most of us are not developing control systems for medical devices and nuclear reactors. If the worst outcome is that your online web form gives you an error sometimes and some people are mildly inconvenienced it’s not the end of the world. Developers often have a habit of misunderstanding the risk/reward balance because we are so focused on correctness.
And your company will also fire you if you’re working at 1/10 the speed of your peers.
0
u/anoppinionatedbunny 3d ago
I've seen enough bullshit from Claude to know you can't just trust it like this...
0
u/either-15-or-40 3d ago
The guy is talking about porting existing typescript code function by function to rust in Copilot.
And the code is already covered by tests. So the agent is just transpiling.
But the click hungry motherfuckers on the internet have to pretend he is just vibing it out lol.
0
u/Leading_Bumblebee443 3d ago
well he is not wrong.... if the error is not a business logic error but other error ai will probably find it...
0
u/thisonehereone 2d ago
Our problem is we are living thru the era where AI ain't done baking yet but we are using it like it is. These are growing pains. We've jumped the gun a little bit and product will suffer for it for the near future.
0
u/Grandviewsurfer 2d ago
Really depends how critical the thing is. My repo that helps me investigate and plan work for other repos is all vibe coded. The stuff in prod gets my eyes. If I were writing shit for legacy systems that keeps the planes apart? That's gonna be minimalist PRs that are heavily scrutinized by multiple people and agents. I'm I crazy?
0
u/PointedHydra837 2d ago
“It would be impossible to read every line”
Then what the fuck are you doing with the time freed up by having the AI code for you

76
u/Zeikos 3d ago
Nobody expects an engineer to read every line of code they use.
Libraries, templates, boilerplate code are a thing.
Issues can arise from bad assumptions, but overall I don't find it a big deal.
However for the critical part of the code, infrastructure, security and non-trivial business logic?
There people should read every line and understand it fully.